Feat: Add manual update and URL change for holiday alarm data#16
Feat: Add manual update and URL change for holiday alarm data#16gx-bangsong merged 1 commit intomainfrom
Conversation
This change adds two new features to the alarm settings page: 1. A preference to manually trigger an update of the holiday and work schedule data. 2. An `EditTextPreference` that allows users to change the URL from which the holiday data is fetched. This provides users with more control over the holiday alarm functionality, allowing them to force an update if the data is stale and to use custom data sources. The following changes were made: - Modified `app/src/main/res/xml/settings_alarm.xml` to add the new preferences. - Added new string resources in English, Simplified Chinese, and Traditional Chinese. - Modified `AlarmSettingsFragment.java` to handle the logic for the new preferences. - Modified `HolidayRepository.java` to use the configurable URL for holiday data. - Added getter and setter methods for the holiday data URL to `DataModel.java` and `SettingsDAO.java`. - Added new preference keys to `PreferencesKeys.java` and a default URL to `PreferencesDefaultValues.java`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. |
1 participant
This change adds two new features to the alarm settings page:
EditTextPreferencethat allows users to change the URL from which the holiday data is fetched.This provides users with more control over the holiday alarm functionality, allowing them to force an update if the data is stale and to use custom data sources.
PR created automatically by Jules for task 17193339429658895192